Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded call to /bin/sh in use-standalone-widevine.sh #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

marcor
Copy link

@marcor marcor commented May 28, 2022

Fix issues #9 and #11.

@GlowingScrewdriver
Copy link

I second this. When fetch-standalone-widevine.sh is executed with a shell other than bash (on Debian, for example, /bin/sh usually points to dash by default), the tests that use [[ fail, since [[ is a bash builtin

I can confirm that with dash as my default shell the script does not work; and that removing the hardcoded call indeed does make it work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants